search

TelluIoT / ThingML

The ThingML modelling language
https://github.com/TelluIoT/ThingML
Apache License 2.0
101 stars 32 forks source link

The JavaScript compiler needs to be updated to support latest version of its state library #267

Closed fungiboletus closed 5 years ago

fungiboletus commented 5 years ago

A major breaking change has been introduced in steelbreeze/state 7.2.0, see steelbreeze/state#12

fungiboletus commented 5 years ago

I'm not sure but I feel like the internal events are broken.

brice-morin commented 5 years ago

Anyway, since we do not have direct control over steelbreeze/state (though the guy is usually quite reactive at fixing issues), it is probably a good idea to be one minor revision behind in the generated JS code, unless we have a good reason to jump to the last version.

brice-morin commented 5 years ago

yes, I can confirm there is something fishy in the newest version of state.

I fixed the version in the generated package.json to 7.0.1, which AFAIK works well for our needs.

mesmo commented 5 years ago

There was a big re-work of transitions - if you have some examples of the issues you're seeing I'll investigate and fix...

mesmo commented 5 years ago

I have found a bug in the triggering of completion transitions after internal transition evaluation; v7.2.2 has been released and hopefully cures the issues you are seeing.

fungiboletus commented 5 years ago

I confirm the bug has been fixed. We probably should update the generator to the new transition syntax at some point, but that's another issue to track.

Thanks again @mesmo

brice-morin commented 5 years ago

Great! Once again, your reactivity on state is very much appreciated, @mesmo