search

TelluIoT / ThingML

The ThingML modelling language
https://github.com/TelluIoT/ThingML
Apache License 2.0
103 stars 32 forks source link

Consider migrating JS compiler towards state lib 8.0.0 #283

Closed fungiboletus closed 5 years ago

fungiboletus commented 5 years ago

As stated here in https://github.com/steelbreeze/state/blob/master/RELEASES.md#v800 steelbreeze/state has breaking changes in its 8.0.0 version.

Someone confident with ThingML should probably run the unit tests with this version.

brice-morin commented 5 years ago

Do you mean the package.json we generate uses by default this new 8.0.0 version? If so, I would first correct that, so as it use a version we know works (in principle, the latest 7.x.y).

Then, we can talk about migrating to 8.x.y :-)

fungiboletus commented 5 years ago

No it does not. We should discuss about the migration.

Le jeu. 4 avr. 2019 à 21:15, Brice Morin notifications@github.com a écrit :

Do you mean the package.json we generate uses by default this new 8.0.0 version? If so, I would first correct that, so as it use a version we know works (in principle, the latest 7.x.y).

Then, we can talk about migrating to 8.x.y :-)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/TelluIoT/ThingML/issues/283#issuecomment-480027611, or mute the thread https://github.com/notifications/unsubscribe-auth/AACyrP7nYtHTcZOVou98nUx_hppt8FDgks5vdk9QgaJpZM4ccvrw .

brice-morin commented 5 years ago

That was what I feared :-)

brice-morin commented 5 years ago

OK, work in progress :-)

Quite a big refactoring in the end, but so far I like the new generated code (though it does not work at this very moment, but I am getting closer)