Have you ever ran eslint on the JavaScript generated code ?

TelluIoT / ThingML

The ThingML modelling language

https://github.com/TelluIoT/ThingML

Apache License 2.0

101 stars 32 forks source link

Have you ever ran eslint on the JavaScript generated code ? #287

Open fungiboletus opened 4 years ago

fungiboletus commented 4 years ago

We did for some reasons.

I think we could take a look at the advice from eslint :

eqeqeq to have safer comparisons. func-names to have better debug traces.

Otherwise once we disable the eslint warnings that we will never fix because it's generated code, it's not so bad. It actually found real errors in the generated code.

brice-morin commented 4 years ago

It would be good if you could run the linter, configured to report only the errors/warnings that you think shoud be fixed, on https://github.com/SINTEF-9012/thingml-diversifier/blob/master/src/main/resources/experiments1/nodejs.thingml

And provide me with the report, then I can have a look.