Open romantomjak opened 4 years ago
Hey @V-Paranoiaque, @carlpett and @aabouzaid from the looks of it you are the top contributors of this repository. Thought I'll ping you guys to get the ball rolling.
Hi @romantomjak I don't use Proxmox anymore and unfortunately cannot help with that. I hope you all the best, it looks a very useful contribution :rocket:
Thank you @aabouzaid. Hopefully I'll hear some good news from others :)
Hey @romantomjak, I'm not actually a maintainer on the repo, I just submitted some patches that I needed. I think you want @ggongaware :) But while I'm here, some thoughts on your general questions:
Thank you @carlpett, that actually makes a lot of sense! I think the last point ties in nicely with test coverage as well which I think is a must!
So maybe I could first start with adding some test coverage and making things more robust along the way?
Sounds like a reasonable start! Although it'll require some setup work, I'd personally suggest aiming for more integration-style tests over than unit tests that mock out Proxmox. Maybe a Vagrant box per Proxmox version, or something similar. The tests will defintely take longer to run, but the confidence will be much higher.
That is a brilliant idea! I'll look into how to setup a proxmox vagrant box as I'm not entirely sure how proxmox virtualization will work inside a VM. Thanks for being so responsive @carlpett ❤️
Hey, I'd like to help to add the vast majority of options available through the Proxmox API. I do have some concerns about client compatibility as I am certain not all options are supported by all versions of Proxmox's API, but unfortunately I have no experience building clients that support multiple versions of APIs.
Couple of questions to get the ball rolling:
Thanks!