github-actions[bot]
commented
1 year ago This issue is stale because it has been open for 60 days with no activity. Please update the provider to the latest version and, in the issue persist, provide full configuration and debug logs
Description
Hello! We are currently using version 2.9.10 of the proxmox-terraform-provider.
We have encountered a critical issue with the proxmox-terraform-provider that, we believe, requires immediate attention. Our infrastructure setup consists of a Kubernetes cluster running on Proxmox virtual machines, and we utilize the proxmox-terraform-provider to manage this infrastructure.
Recently, while attempting to add a group of production-related nodes, we encountered an incident. We copied and modified a manifest file, keeping the VMID unchanged. However, it appears that the provider failed to validate the existing VMID resources during the terraform plan phase and did not raise any warnings or errors during terraform apply.
The output of terraform plan indicated the list of new VMs to be created, along with the following summary:
Plan: 3 to add, 0 to change, 0 to destroy.
However, when we proceeded with the terraform apply command, the provider once again failed to validate the existing VMIDs and applied the new manifest values to the existing VMs. This resulted in unintended changes being made to the existing infrastructure, leading to a critical incident.
Expected Behavior:
We expect the proxmox-terraform-provider to properly validate existing resources based on their VMID and provide accurate information in the terraform plan output. In this case, the provider should have identified that the resources with the specified VMIDs already existed and alerted us to the potential modification of existing nodes instead of falsely indicating the creation of new ones.
We kindly request the development team's prompt attention to investigate this issue and provide a fix. It is crucial for the provider to perform adequate validation and prevent unintended modifications to the existing infrastructure. We appreciate your assistance in swiftly resolving this matter.
Best regards!