search

Temasys / AdapterJS

AdapterJS Javascript Polyfill and Tools for WebRTC - Skylink WebRTC
http://skylink.io/web
Other
432 stars 100 forks source link

grunt jshint errors out #161

Closed zirho closed 8 years ago

zirho commented 8 years ago

I freshly cloned repo and did what is in instruction in README and got this

`Running "jshint:build" (jshint) task

124 |              if (filePath.indexOf(grunt.config.get('googleAdapterPath')) != -1) {
                                                                                 ^ Expected '!==' and instead saw '!='.

1 error in 2 files Warning: Task "jshint:build" failed. Use --force to continue.

Aborted due to warnings. AdapterJS (master) $`

johache commented 8 years ago

Hi, good catch, thanks for the feedback. Fixed it here with a bunch of other issues : https://github.com/Temasys/AdapterJS/pull/162 Wait for the PR to be validated :)

Meanwhile, you can still run grunt publish to generate your AJS. grunt jshint just checks the js for typos, and style.

zirho commented 8 years ago

Hi, no problem. I appreciated quick response.

johache commented 8 years ago

PR merged and released: https://github.com/Temasys/AdapterJS/releases/tag/0.13.1

I am closing this issue, please feel free to re-open it if relevant.