global objects should be exported or set to window object

[zdila]

It is impossible to get attachMediaStream when using webpack and source

import AdapterJS from 'adapterjs';

Object AdapterJS has no reference to attachMediaStream or other objects/functions.

window.RTCPeerConnection is available (because it is set to the window object)

[johache]

I am not familiar with webpack. attachMediaStream is an attribute of AdapterJS. It is a global function. Did you take this in account ?

[zdila]

Maybe I do something wrong, but in my case AdapterJS.attachMediaStream is undefined. It contains only following properties: > Object.keys(AdapterJS) < ["options", "VERSION", "onwebrtcready", "_onwebrtcreadies", "webRTCReady", "WebRTCPlugin", "onwebrtcreadyDone", "maybeThroughWebRTCReady", "TEXT", "_iceConnectionStates", "_iceConnectionFiredStates", "isDefined", "parseWebrtcDetectedBrowser", "maybeFixConfiguration", "addEvent", "renderNotificationBar"]

Regarding Webpack - it just packages the modules from npm (and bower) to single bundle.js. If a module uses global variables, they are treaten as module-local variables and are not visible to other modules. But assigning to window.attachMediaStream should work. Also it is possible to tell Webpack to bind module-local variables of specific module to window so I can work it around. They say it is for "broken" modules.

[johache]

oops, I missed the not... attachMediaStream is NOT an attribute of AdapterJS.

you should be able to access it globally.

[zdila]

OK, I can. But I must tell webpack to treat AdapterJS as "broken" module.

To "fix" it there may be more alternatives. One of:

• assign global variables to window (eg. window.attachMediaStream = ...)
• export globals from the module
• assign globals to AdapterJS object (AdapterJS is currently the only thing exported)

[johache]

@ncurrier I'm fine with setting window.attachMediaStream = attachMediaStream Any opinion on this ?

[zdila]

It was hard but my workaround (using Webpack) is:

const ajs = require("imports?module=>false!exports?AdapterJS&attachMediaStream&getUserMedia&RTCPeerConnection&createIceServer!adapterjs");
const {AdapterJS, attachMediaStream, getUserMedia, RTCPeerConnection, createIceServer} = {...ajs};

[johache]

I'll add attachMediaStream in AdapterJS and in window either today or tomorrow

[johache]

PR open : https://github.com/Temasys/AdapterJS/pull/165

[johache]

PR merged and released: https://github.com/Temasys/AdapterJS/releases/tag/0.13.1

I am closing this issue, please feel free to re-open it if relevant.

[zdila]

All public properties should be added to window or better - should be exported from the module.

My current working solution (workaround) for webpack is to import adapterjs like this:

require('!script!adapterjs/publish/adapter.debug.js');

[johache]

I agree. @letchoo we should do that in the near-ish future.