Closed oooookk7 closed 8 years ago
Tested in http: protocol environment compiled with browserify using SkylinkJS test scripts compilation.
http:
I followed the logic @johache had to resolve PR #173 fixes.
(PASS) Firefox 45
webrtcDetectedBrowser
"firefox"
webrtcDetectedVersion
45
webrtcMinimumVersion
31
(PASS) Chrome 49
"chrome"
49
38
(PASS) Safari 8.0.6
"safari"
8
7
(PASS) Opera 35
"opera"
35
26
SecurityError
https:
PermissionDeniedError
Error
Moved your code inside AdapterJS.parseWebrtcDetectedBrowser. Tested ok for me. Please merge if you are happy with the result :)
AdapterJS.parseWebrtcDetectedBrowser
Ok. Looks good.
Tested in
http:
protocol environment compiled with browserify using SkylinkJS test scripts compilation.I followed the logic @johache had to resolve PR #173 fixes.
Testing in adapter.debug.js file
(PASS) Firefox 45
webrtcDetectedBrowser
->"firefox"
webrtcDetectedVersion
->45
webrtcMinimumVersion
->31
(PASS) Chrome 49
webrtcDetectedBrowser
->"chrome"
webrtcDetectedVersion
->49
webrtcMinimumVersion
->38
(PASS) Safari 8.0.6
webrtcDetectedBrowser
->"safari"
webrtcDetectedVersion
->8
webrtcMinimumVersion
->7
(PASS) Opera 35
webrtcDetectedBrowser
->"opera"
webrtcDetectedVersion
->35
webrtcMinimumVersion
->26
Testing in adapter.screenshare.js file
(PASS) Firefox 45
webrtcDetectedBrowser
->"firefox"
webrtcDetectedVersion
->45
webrtcMinimumVersion
->31
SecurityError
as not inhttps:
protocol environment.(PASS) Chrome 49
webrtcDetectedBrowser
->"chrome"
webrtcDetectedVersion
->49
webrtcMinimumVersion
->38
PermissionDeniedError
for retrieval of audio as not inhttps:
protocol environment.(PASS) Opera 35
webrtcDetectedBrowser
->"opera"
webrtcDetectedVersion
->35
webrtcMinimumVersion
->26
Error
that current browser does not support screensharing because I am not using a commercial plugin.(PASS) Safari 8.0.6
webrtcDetectedBrowser
->"safari"
webrtcDetectedVersion
->8
webrtcMinimumVersion
->7
Error
that current plugin does not support screensharing