Temasys / AdapterJS

AdapterJS Javascript Polyfill and Tools for WebRTC - Skylink WebRTC
http://skylink.io/web
Other
432 stars 100 forks source link

AJS-253: Fixes for undefined webrtcDetectedBrowser, webrtcDetectedVersion and webrtcMinimumVersion using browserify #179

Closed oooookk7 closed 8 years ago

oooookk7 commented 8 years ago

Tested in http: protocol environment compiled with browserify using SkylinkJS test scripts compilation.

I followed the logic @johache had to resolve PR #173 fixes.


Testing in adapter.debug.js file

(PASS) Firefox 45

(PASS) Chrome 49

(PASS) Safari 8.0.6

(PASS) Opera 35

(PASS) Firefox 45

(PASS) Chrome 49

(PASS) Opera 35

(PASS) Safari 8.0.6

johache commented 8 years ago

Moved your code inside AdapterJS.parseWebrtcDetectedBrowser. Tested ok for me. Please merge if you are happy with the result :)

oooookk7 commented 8 years ago

Ok. Looks good.