search

Temasys / AdapterJS

AdapterJS Javascript Polyfill and Tools for WebRTC - Skylink WebRTC
http://skylink.io/web
Other
429 stars 100 forks source link

change MediaStreamTrack from Object to Function type. #201

Closed nasivuela closed 8 years ago

nasivuela commented 8 years ago

MediaStreamTrack is implemented by the browsers as an instance of function (with prototype), the current polyfill implementation as an object make this kind of check raise an error:

window.MediaStreamTrack  && 'aMethod' in window.MediaStreamTrack.prototype
johache commented 8 years ago

LGTM. @letchoo good for you too ? Is that ok with SkylinkJS ?

oooookk7 commented 8 years ago

Is fine for me. SkylinkJS has not implemented MediaStreamTrack yet anw.

johache commented 8 years ago

Merged, thanks for the contribution @nasivuela :)

johache commented 8 years ago

(note: I just realised the PR was on master.... too late, need to make sure this is clean on the next release)

nasivuela commented 8 years ago

Sorry about that, I can make the PR on develop if you prefer.

johache commented 8 years ago

That's fine, I merged it already. It's my mistake, I went a bit too fast.

Don't worry about it and thanks for the PR :)