Add AdapterJS to window object

Temasys / AdapterJS

AdapterJS Javascript Polyfill and Tools for WebRTC - Skylink WebRTC

http://skylink.io/web

Other

432 stars 100 forks source link

Add AdapterJS to window object #246

Closed aszmyd closed 7 years ago

aszmyd commented 7 years ago

I've added this one because when i requite this plugin with webpack, it does not put the AdapterJS object into global window object but i need it to detect browser support and plugin installation status.

johache commented 7 years ago

@aszmyd, please do you PR on dev, not master. Also, you don't need to push modifications on publish, we will re-generate these files on the next release.

@ncurrier I'm not sure we should put AdapterJS in the window scope. That sounds against basic npm encapsulation principles. What do you think ?

aszmyd commented 7 years ago

@johache is it an issue that those changes are in publish folder also? Should i revert them?