search

Temasys / AdapterJS

AdapterJS Javascript Polyfill and Tools for WebRTC - Skylink WebRTC
http://skylink.io/web
Other
428 stars 100 forks source link

AJS-286 supporting constraint format for device id in webrtcSamples #266

Closed miniruwan closed 7 years ago

miniruwan commented 7 years ago

Refer the ticket for details

oooookk7 commented 7 years ago

@miniruwan I suggest not setting r.exact = undefined; unless if there is a reason for this?

johache commented 7 years ago

LGTM, except for the indenting. Please use 2 spaces indent. You can merge after that.

miniruwan commented 7 years ago

@letchoo commented on 2017 M05 23 17:53 GMT+8:

@miniruwan I suggest not setting r.exact = undefined; unless if there is a reason for this?

This is intentional @letchoo. This is to avoid getting into the if condition below if (r.exact !== undefined && typeof r.exact !== 'number')

miniruwan commented 7 years ago

@johache commented on 2017 M05 24 10:10 GMT+8:

LGTM, except for the indenting. Please use 2 spaces indent. You can merge after that.

done.