Temasys / AdapterJS

AdapterJS Javascript Polyfill and Tools for WebRTC - Skylink WebRTC
http://skylink.io/web
Other
432 stars 100 forks source link

Add support for Bowser #43

Open paericksen opened 9 years ago

paericksen commented 9 years ago

Bowser from Ericsson supports webrtc, but it doesn't seem to work with adapter.js. Please update adapter.js to support Bowser.

serrynaimo commented 9 years ago

Hey paericksen,

thanks for pointing that out. We'll take a look. If you've any specific knowledge on why it doesn't work, we'll appreciate it.

paericksen commented 9 years ago

not sure if this is needed or not... according to their wiki, bowser has the following user-agent string:

Mozilla/5.0 (iOS; like Mac OS X) AppleWebKit/536.36 (KHTML, like Gecko) not Chrome/27.0.1500.95 Mobile/10B141 Safari/537.36 Bowser/0.2.1

https://github.com/EricssonResearch/bowser/wiki/Developing-for-Bowser

EvilTrev commented 9 years ago

@serrynaimo Did this go anywhere? I'm trying the demo getaroom.io on Bowser and not having much luck.

serrynaimo commented 9 years ago

It's on the list, but I can't yet put a date on when or if AdapterJS will be updated to support Bowser. The app has limited reach and we currently have the limited resources we have work on bringing WebRTC to webkit directly.

EvilTrev commented 9 years ago

@serrynaimo That would be awesome too... pretty much the only reason to consider Bowser is that it is open source and with a few tweaks you can have a WebRTC enabled WebView/App. If Temasys have their own bolt-on to the WKWebView or UIWebView, I'd love to see that.

serrynaimo commented 9 years ago

I see. If you need WebRTC in an iOS app, take a look at http://skylink.io/ios in the mean-time ;)

esase commented 8 years ago

Any news, when it will be added?

s1h4d0w commented 8 years ago

Checking in to see if there is any news regarding Bowser support in Adapter.js. Is there any way to add support ourselves? We have a company that develops a webrtc application for us and they're saying that they can't make our application work with Bowser until Adapter.js is updated but I fully understand that this is an open source project.

My case is that Bowser has been updated recently and it has gotten considerable attention. It seems to be maturing and could be a great browser for non native applications on iOS.

johache commented 8 years ago

Hi s1h4d0w, hi all,

We are indeed interested in adding support for Bower, however, we don't quite have the resources to allocate to implementing it. If anyone was to send a pull request for that, we would gladly review it and help fixing remaining issues.

Alternatively, you can create a pull request on Google's adapterJS (https://github.com/webrtc/adapter), which will soon be directly extending.

s1h4d0w commented 8 years ago

Hi johache,

My personal knowledge of Javascript and WebRTC is sadly very limited. I'll see if my employer would want to hire our developer to create a pull request (if they have the knowledge) as it's important for our product.

suoc commented 8 years ago

is it still not supported???