Temasys / SkylinkJS

SkylinkJS Javascript WebRTC SDK
http://skylink.io/web
Other
275 stars 57 forks source link

[Bower] Incorrect dependency in 0.6.7 - socket.io client #190

Closed cristiano-belloni closed 8 years ago

cristiano-belloni commented 8 years ago

Trying to install Skylinkjs 0.6.7 with bower, I see this error:

bower skylinkjs#~0.6.7 cached git://github.com/Temasys/SkylinkJS.git#0.6.7 bower skylinkjs#~0.6.7 validate 0.6.7 against git://github.com/Temasys/SkylinkJS.git#~0.6.7 bower sio-client#1.3.7 not-cached git://github.com/shSina/socket.io-client.git#1.3.7 bower sio-client#1.3.7 resolve git://github.com/shSina/socket.io-client.git#1.3.7 bower sio-client#1.3.7 ENORESTARGET No tag found that was able to satisfy 1.3.7

Looking at the socket.io-client bower repo, there's no 1.3.7 release, latest is 1.3.6: https://github.com/shSina/socket.io-client/releases

Could you please fix the dependency so bower users can use 0.6.7?

Thanks.

ncurrier commented 8 years ago

thanks for reporting this issue.

cristiano-belloni commented 8 years ago

I think the error is here: https://github.com/Temasys/SkylinkJS/blob/master/bower.json#L28

Please tell me we don't have to wait for 0.6.8 to see the fix :/

ncurrier commented 8 years ago

We will be releasing a 0.6.8 release to address this issue on Monday morning Singapore time. This will have to go through our internal release process to make this happen and validate, we as a rule do not release during non-office hours unless it is a critical issue, apologies for the delay.

cristiano-belloni commented 8 years ago

Btw I contacted the mantainer of the socket.io-client repo, it seems he's adding all the socket.io releases.

ncurrier commented 8 years ago

awesome, thanks.

oooookk7 commented 8 years ago

Hi @janesconference,

This is fixed in the release ver 0.6.8.

cristiano-belloni commented 8 years ago

thanks!