search

Temasys / SkylinkJS

SkylinkJS Javascript WebRTC SDK
http://skylink.io/web
Other
275 stars 57 forks source link

[0.6.7]: shareScreen() callback is not triggered #198

Closed oooookk7 closed 8 years ago

oooookk7 commented 8 years ago

Noticed bug was that when users are in the room, the shareScreen() callback is not triggered.

This could be due to the issue as pointed in this part of the code https://github.com/Temasys/SkylinkJS/blob/master/source/stream-media.js#L2246

oooookk7 commented 8 years ago

This would be resolved in 0.6.10 (version is re-decided)

edushare commented 8 years ago

any update on this issue?

oooookk7 commented 8 years ago

Hi @edushare, this fixes are in our timeline however I cannot give a fixed date when this will happen as we are currently busy with other priorities.

Meanwhile, a suggestion is to use the mediaAccessSuccess event for the success callback and the mediaAccessError event for the error callback in which you can detect if stream error or success is from shareScreen() function from the event payload isScreensharing flag.

Sorry for the inconvenience. We will keep you informed in which release versions this fixes will be in when we release it.

JanNorden commented 8 years ago

The same issue seems to exist with sendStream().

oooookk7 commented 8 years ago

Hi @JanNorden, thanks for pointing it out. For now as a workaround, the same solution provided above would work.

oooookk7 commented 8 years ago

Resolved in 0.6.15 release.