search

Temasys / SkylinkJS

SkylinkJS Javascript WebRTC SDK
http://skylink.io/web
Other
275 stars 57 forks source link

Using npm library generates warning about minified version #240

Closed drujensen closed 6 years ago

drujensen commented 8 years ago

when I install the skylinkjs library using npm install --save skylinkjs and compile using webpack

I get this warning: WARNING in ./~/skylinkjs/publish/skylink.complete.min.js 09:09:05 client.1 | Critical dependencies: 09:09:05 client.1 | 2:760-767 This seems to be a pre-built javascript file. Though this is possible, it's not recommended. Try to require the original source to get better results.

oooookk7 commented 8 years ago

Hi @drujensen, thanks for pointing out. The case is that we are using the a bundled version as the "main" script in package.json. This might be a Webpack specific issue as noted in here, and to suppress the warnings, you may follow a solution posted by a user in the same github issue link in here.

Currently, as we are having other priorities right now, we will look into optimising our module with webpack in the future to prevent such warnings. Contributions are appreciated as PR to the 0.6.x-development branch.

drujensen commented 8 years ago

thanks @letchoo. I understand about priorities and will take a look at this if I get a chance.