search

Temasys / SkylinkJS

SkylinkJS Javascript WebRTC SDK
http://skylink.io/web
Other
275 stars 57 forks source link

Missing close button in unsupported browser - safari mobile 10 #279

Closed erichstark closed 7 years ago

erichstark commented 7 years ago

Hello SkylinkJS team, I found a bug on safari mobile, when library is not supported it is not possible to close this warning. And therefore webpage is not usable beacause on top of page we have "hamburget button" for menu. Is there any workaround?

img_1302

oooookk7 commented 7 years ago

Hey @erichstark,

This is a styling issue caused by the AdapterJS.renderNotificationBar() function from the AdapterJS dependency that SkylinkJS uses.

To resolve this issue, you might need to modify the adapter.screenshare.js file and tweak the CSS to suit your webpage and use your own customized modified AdapterJS dependency.

You might need to reference the dependencies separately though if you are using skylink.complete.js as it would be pointing to the different versions of the dependencies since it is a compiled version of SkylinkJS+AdapterJS+socket.io-client:

<-- recommended order -->
<script src="https://cdn.socket.io/socket.io-1.4.8.js"></script>
<script src="my-adapter.screenshare.js"></script>
<script src="https://cdn.temasys.com.sg/skylink/skylinkjs/0.6.x/skylink.debug.js"></script>
oooookk7 commented 7 years ago

I'll be closing this ticket on this github project as well since this issue stems from AdapterJS, and if there is any issues, please open a ticket on the AdapterJS project here.