Temasys / SkylinkJS

SkylinkJS Javascript WebRTC SDK
http://skylink.io/web
Other
275 stars 57 forks source link

ESS-1336 - Setting remoteDescription (answer) fails on Firefox 63.0.3 | MCU key only #364

Closed ishannaithani closed 5 years ago

ishannaithani commented 5 years ago

Purpose of this PR: The purpose is to fix the issue where on Firefox 63.0.3 (latest version as of this PR) the setting of remoteDescription sdp answer in _answerHandler fails with an error:

Please note that this exception occurs when MCU is enabled.

DOMException: Failed to parse SDP. SDP Parse error on line 53: No sctp port specified in m= media line, parse failed

What was changed The m=application is saved in a variable when the browser (FF) generates the offer. When MCU sends the answer, the m=application line is replaced with the one from the offer sdp. This happens only for Firefox 63 and above when MCU is on.

See ESS-1336 for more details.