Temasys / SkylinkJS

SkylinkJS Javascript WebRTC SDK
http://skylink.io/web
Other
275 stars 57 forks source link

ESS-1602: Firefox DTLS issue fixes #395

Closed ishannaithani closed 5 years ago

ishannaithani commented 5 years ago

Purpose of this PR:

  1. Firefox incorrectly generates "a=setup" line in answer when negotiated DTLS role is "passive". This PR includes a fix to ensure that renegotiation and outgoing answer from Firefox have the correct role in SDP.

Original Bugzilla(#1240897): https://bugzilla.mozilla.org/show_bug.cgi?id=1240897 To be released: 9th July, 2019

  1. Added Case for screenshare: When screen-sharing, if video track's RTCRTPSender is not available, replaceTrack is not possible. Hence, SDK should renegotiate.

  2. Added case for Microsoft Edge in unified-mode - getDisplayMedia is available at navigator.getDisplayMedia

  3. Fix for: MS Edge when offering does not add an \r\n to the end of the SDP

See ESS-1602 for more details.