Fails on attempt to rename Icon.png to default.tbn if there's both.

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Install Hitcher's Repo
2. Install iPlayer from Videos

What is the expected output? What do you see instead?
Will fail due to failed renaming of Icon.png to default.tbn, as default.tbn 
already exists (succeeds and works if Icon.png is removed from the addon .zip 
file)

What version of the product are you using? On what operating system?
0.9.3

Please provide any additional information below.

Original issue reported on code.google.com by geeky...@gmail.com on 1 Jul 2012 at 3:53

[GoogleCodeExporter]

Original comment by FrostBox360 on 15 Aug 2012 at 2:15

[GoogleCodeExporter]

before I do my first commit - here is my fix for this. I initially just checked 
to see if the dest file existed in ItemInstaller.py but then I thought it would 
be useful if the renameItem call could handle when dest file exists. I added a 
"force" parameter currently defaulting to false (old behaviour), so that you 
can force a rename which will delete the destination first. along with this, I 
simplified the renameItem code as it had some duplication (two sets of 
os.rename depending on whether path set). I also removed some checks that 
existed when there was no base path set, as the exception handling will take 
care of it, as well as the fact it only checked then and not when there was a 
base path.

Original comment by exob...@gmail.com on 15 Nov 2012 at 8:36

[GoogleCodeExporter]

updated patch without whitespace error.

Original comment by exob...@gmail.com on 15 Nov 2012 at 8:41

[GoogleCodeExporter]

Original comment by exob...@gmail.com on 15 Nov 2012 at 8:41

Attachments:

• rename_force.diff

[GoogleCodeExporter]

Looks good, more efficient. Go ahead you can commit. Thanks!

Original comment by tem...@gmail.com on 15 Nov 2012 at 11:02

[GoogleCodeExporter]

resolved in r1164

Original comment by exob...@gmail.com on 16 Nov 2012 at 12:10

• Changed state: Fixed