search

Temperz87 / ultra-mod-manager

A WIP mod manager for ULTRAKILL, that works with BepInEx and UKMods
MIT License
24 stars 21 forks source link

Lots of changes #10

Closed TeamDoodz closed 1 year ago

TeamDoodz commented 1 year ago

Originally this PR was just going to rename some things, but I went a bit overboard.

Temperz87 commented 1 year ago

My main issue with this pull request is I'm pretty sure renaming all these fields doesn't really accomplish much while also breaking every existing UKMod.

TeamDoodz commented 1 year ago

renaming all these fields doesn't really accomplish much

I had renamed them not only to fit the C# naming conventions but to also be more descriptive/make more sense, which makes the code more intuitive.

while also breaking every existing UKMod

Is that not the reason why UMM is in prerelease? According to the readme: "This mod manager is currently in Alpha, and is subject to make mod breaking changes".

You can always wait until the next major release before you make breaking changes (as is the standard for software development).

distributivgesetz commented 1 year ago

You can always wait until the next major release before you make breaking changes (as is the standard for software development).

This is why clear API versioning is important.