Closed Hydraxous closed 1 year ago
I'd like to know more on why you decided to use delegate
instead of UnityEvent
for the events, because UKKeyBind
uses UnityEvent
so it may be a good idea to just standardize this, but other than that looks good.
UnityEvents are much less efficient and convienient to use than regular c# events. The purpose of UnityEvents is that they can be serialized and assigned in the inspector, but since nothing in UMM is actually serialized there is no reason to actually use them.
Sounds good, merged.
to quote myself for the sake of explanation "I used delegate because that's just what I'm familiar with if UnityEvent will work better I can fix it"