Temperz87 / ultra-mod-manager

A WIP mod manager for ULTRAKILL, that works with BepInEx and UKMods
MIT License
24 stars 21 forks source link

UKAPI Level context help functions #15

Closed Hydraxous closed 1 year ago

Hydraxous commented 1 year ago
Temperz87 commented 1 year ago

I'd like to know more on why you decided to use delegate instead of UnityEvent for the events, because UKKeyBind uses UnityEvent so it may be a good idea to just standardize this, but other than that looks good.

TeamDoodz commented 1 year ago

UnityEvents are much less efficient and convienient to use than regular c# events. The purpose of UnityEvents is that they can be serialized and assigned in the inspector, but since nothing in UMM is actually serialized there is no reason to actually use them.

Temperz87 commented 1 year ago

Sounds good, merged.

Hydraxous commented 1 year ago

to quote myself for the sake of explanation "I used delegate because that's just what I'm familiar with if UnityEvent will work better I can fix it"