Templarian / MaterialDesign-React

Dist for Material Design Icons React Component for JS/TypeScript
https://materialdesignicons.com
MIT License
139 stars 20 forks source link

`spin` broken in Safari #68

Closed versoworks closed 2 years ago

versoworks commented 2 years ago

Using Safari v15.4, spin property does not work. Tested on https://templarian.github.io/@mdi/react/

@Templarian have you had an opportunity to investigate this issue?

Haosik commented 2 years ago

Might help someone, as a workaround for my "spinner loader" with mdiLoading (and styled-component) I ended up with

const RotatingIcon = styled(Icon)`
  animation: ${rotate} 1s linear infinite;
`

and then rendering it like

<RotatingIcon
      path={mdiLoading}
      horizontal
      vertical
     ... some other props here but without spin
    />

It makes rotating the whole svg which appears to work in Safari.

ngburke commented 2 years ago

@Templarian if someone puts up a pull request for this, would you consider merging it? Thanks!

Templarian commented 2 years ago

@ngburke Yes. This fell off my radar with the busy summer. 100% would merge a PR for this.

ngburke commented 2 years ago

@Templarian PR #72 up for your review, thanks.

Templarian commented 2 years ago

Released 1.6.1