search

Templarian / MaterialDesign-Webfont

@mdi/font Dist for Material Design Icons.
https://materialdesignicons.com
Other
402 stars 157 forks source link

Add font-display: swap ? #47

Closed batkor closed 5 years ago

batkor commented 5 years ago

Hi guys! This best project. i think, best practical if add font-display: swap; in ./@mdi/font/scss/_path.scss

@font-face {
  ...
  ...
  font-display: swap;
}

Google recommended :-) https://developers.google.com/web/updates/2016/02/font-display

tagliala commented 5 years ago

Hi,

we were discussing this at Font Awesome but I think that swap should be avoided for icon fonts.

swap means that character will render (probably) as a square and then refreshed with the intended icon. The best option is still block, and it is probably the same as auto

Ref: FortAwesome/Font-Awesome#14387

Templarian commented 5 years ago

Agreed, looking at the spec that looks like something we should avoid. The default behavior (auto/block) is what we would want in this case, so leaving it off should be fine.

Wish there was a option that sets it a high priority for fonts that use private characters where there isn't a reasonable fallback.

batkor commented 5 years ago

Thank, Ok