search

Templarian / MaterialDesign-Webfont

@mdi/font Dist for Material Design Icons.
https://materialdesignicons.com
Other
402 stars 157 forks source link

adding ability to preload from cache #62

Closed iamntg closed 4 years ago

iamntg commented 4 years ago

as I mentioned in the issue #61 [https://github.com/Templarian/MaterialDesign-Webfont/issues/61],

please do review and merge this

iamntg commented 4 years ago

@Templarian

francoism90 commented 4 years ago

@iamntg How does this work?

tagliala commented 4 years ago

I would avoid this approach because if you rely on the font installed on the system, then icons from new updates will not work

Templarian commented 4 years ago

Agreed with all the comments here. Installing the font locally is not something we advise (we actually advise heavily against this).

This is also a distribution repo. https://github.com/Templarian/MaterialDesign-Font-Build Is the repo you want for modification.

iamntg commented 4 years ago

I did that mainly for the PWA applications. as per pwa standards, the static files should load from cache first, on the initial load(First Contentful Paint). so, preloading the fonts like that would help. and the service worker can update the font if there is a change.