Closed stefan-schweiger closed 8 years ago
OK, after thinking more about this and looking how other font libraries, like Font Aweseom, handle their bower.json files it kind of makes sense to include the font files and the materialdesignicons.scss
. Because else it will be cumbersome to handle the assets and styles dynamically with gulp/grunt tasks.
But I still would suggest to only include one file per filetype, no minified file and no globs.
"main": [
"css/materialdesignicons.css",
"scss/materialdesignicons.scss",
"fonts/materialdesignicons-webfont.eot",
"fonts/materialdesignicons-webfont.svg",
"fonts/materialdesignicons-webfont.ttf",
"fonts/materialdesignicons-webfont.woff",
"fonts/materialdesignicons-webfont.woff2"
]
AFAIK, in the new bower specifications, if there is a .less or .scss file, you should not include the .css
People needing .css should override their bower.json
Refers to https://github.com/FortAwesome/Font-Awesome/pull/6227 http://blog.getbootstrap.com/2015/06/15/bootstrap-3-3-5-released/#wiredep-and-bower https://github.com/bower/bower.json-spec/issues/47
Hope it helps
@tagliala thanks for pointing this out!
I guess many people are using bower with wiredep, so we should probably not break this until the issues are resolved. But still having the min.css
in there also messes with wiredep, so this still not belongs in there.
+1 on improving this. By now, I am relying on Bower's overrides
section, with something like that:
"overrides": {
"mdi": {
"main": [
"scss/materialdesignicons.scss"
]
}
}
This change will be in the next release by the way. Was an oversight it didn't get into the 1.6.50
release.
https://github.com/Templarian/MaterialDesign-Webfont/blob/master/bower.json
I think v1.7.12
fixed this. Let me know if there are any other changes needed.
From the bower.json spec:
Because of this with your current configuration wiredep always includes the normal an the minfied css file.
So the main section should only include the css file: