search

Templarian / MaterialDesign-Webfont

@mdi/font Dist for Material Design Icons.
https://materialdesignicons.com
Other
402 stars 157 forks source link

MDI Variable $sizes is conflicting with bootstrap #70

Closed npoggenburg closed 4 years ago

npoggenburg commented 4 years ago

Hi,

the variable $sizes you are using in this packages is conflicting with bootststrap: // This variable affects the .h-* and .w-* classes. $sizes: () !default; // stylelint-disable-next-line scss/dollar-variable-default $sizes: map-merge( ( 25: 25%, 50: 50%, 75: 75%, 100: 100%, auto: auto ), $sizes );

used in: node_modules/bootstrap/scss/utilities/_sizing.scss

For best practice, the scss vars should be prefixed with mdi- so your variables are like $mdi-sizes to prevent any conflicts with other code.

Best regards, Nico

Templarian commented 4 years ago

@npoggenburg There are no variables called $sizes. That was patched back in Feb 19, 2018.

https://github.com/Templarian/MaterialDesign-Webfont/commit/31ea782ab75a528350d6a350a722ddade6d16596#diff-dde4a3ede9ecb8fd275ea5a53cbf52d2