Templarian / MaterialDesign

✒7000+ Material Design Icons from the Community
https://materialdesignicons.com
Other
10.99k stars 720 forks source link

Gas detector #5516

Closed chemelli74 closed 3 years ago

chemelli74 commented 3 years ago

I have:

Usage

IoT devices are everyday more present in our houses; as a HomeAssistant contributor, I think a specific icon would be nice to have.

Examples

Include any example images so we know what the icon should look like.

One idea for on/off: image image

Xenomorph99 commented 3 years ago

We already have molecule-co and molecule-co2. Would these sensor variants work?

molecule-co-sensor molecule-co2-sensor

molecule-sensor.zip

Xenomorph99 commented 3 years ago

We should probably include the "off" variants as well.

molecule-co-sensor-off molecule-co2-sensor-off

molecule-sensor-off.zip

chemelli74 commented 3 years ago

LGTM !!!

Templarian commented 3 years ago

Off becomes un-readable, so lets leave those out for now.

Xenomorph99 commented 3 years ago

Now that you mention it @Templarian, I agree that you can't read "CO" and "CO2" with the slash. Let's go ahead and add the sensor variants: molecule-co-sensor and molecule-co2-sensor.

@chemelli74, you might be able to distinguish between an "on" and "off" state in your project by changing color instead of changing the icon.

chemelli74 commented 3 years ago

@chemelli74, you might be able to distinguish between an "on" and "off" state in your project by changing color instead of changing the icon.

In HomeAssistant, for on/off sensors we need 2 icons; https://www.home-assistant.io/images/screenshots/binary_sensor_classes_icons.png

What if you use https://image.shutterstock.com/z/stock-vector-gas-sensor-icon-monochrome-style-design-from-sensors-collection-ux-and-ui-pixel-perfect-gas-1188262543.jpg ?

The word CO2 seems lower enough to be still readable in the off version.

Thx a lot for your work,

Simone

Templarian commented 3 years ago

A cloud + sensor might work. But we would have to leave out the text in that case.

mririgoyen commented 3 years ago

Icons with text are special case icons. The original CO and CO2 icons were special cases added after much debate. These variant further complicate these. I do not think these should be added and believe we should reject this issue or come up with a less-literal variation that can solve the use case without the use of letters and numbers.

chemelli74 commented 3 years ago

Then we can go with @Templarian suggestion

temaprint commented 3 years ago

hard to find a similar but maybe these will help https://icons8.com/icons/set/co2

chemelli74 commented 3 years ago

A cloud + sensor might work. But we would have to leave out the text in that case.

I think this is the best solution. Can you be so kind and proceed ? :-)

Simone

chemelli74 commented 3 years ago

@Templarian, any chance to see this committed ? ;-)

Thx in advance,

Simone

chemelli74 commented 3 years ago

Bump ;-)

chemelli74 commented 3 years ago

Few more ideas:

image

image

image

chemelli74 commented 3 years ago

None of the proposal make sense ?

Thx in advance for the feedback,

Simone

chemelli74 commented 3 years ago

@Xenomorph99, @Templarian, @temaprint, @goyney: Should I look for some other sample or one of the proposal above can be accepted ?

Simone

Templarian commented 3 years ago

Gas burner icon is a good idea, but little different than the request. Definitely a good icon to have. With an -off

chemelli74 commented 3 years ago

do you plan to add those ?

Simone

chemelli74 commented 3 years ago

@Templarian, are you considering the addition of this 2 icons (on/off) to the package ?

Thx in advance for your feedback.

Simone

chemelli74 commented 3 years ago

Any decision on those 2 icons ?

Simone

mririgoyen commented 3 years ago

@chemelli74 We're all volunteers here. Constantly pinging an issue with nothing new isn't helpful, it's noise.

That being said, this issue is for an icon depicting a gas detector of which no suitable suggestions or contributions have yet been posted. The side conversation about a gas burner seems like something worthy to add but must be requested in a separate issue so it can be tracked appropriately.

chemelli74 commented 3 years ago

First of all, let me thank you for taking the time to answering.

@chemelli74 We're all volunteers here.

I perfectly know what it means: I'm a volunteer in many projects since more than 15 years.

Constantly pinging an issue with nothing new isn't helpful, it's noise.

I always though that any requester deserve an answer; Last update is from 3 months ago, didn't ping every day 😉

That being said, this issue is for an icon depicting a gas detector of which no suitable suggestions or contributions have yet been posted. The side conversation about a gas burner seems like something worthy to add but must be requested in a separate issue so it can be tracked appropriately.

As you can easily see, finally got an answer! Nobody wrote anything in this direction before 😊

Will close this issue and open a new one once back home and with a pc on my hands.

Regards,

Simone

chemelli74 commented 3 years ago

The side conversation about a gas burner seems like something worthy to add but must be requested in a separate issue so it can be tracked appropriately.

Closing, follow-up here: https://github.com/Templarian/MaterialDesign/issues/6153

Simone