ammunition-magazine - Githubissues

adlaws commented 3 years ago

Generic icons for magazines of ammunition, a "primary" and an alternate one.

Aimed at supplementing the existing mdi-ammunition icon, and for being useful in FPS games and so on.

I have:

[x] Searched the current library to make sure the icon doesn't exist.
[x] Searched open issues to make sure there isn't a request for this icon.
[x] Followed the material guidelines.

Preview

Zip Download

ammunition-magazine.zip

Templarian commented 3 years ago

Do these clip types have specific names we could use?

adlaws commented 3 years ago

Hmmm... that's a good question, and I'm hardly an expert… 😅

Both are "box" magazines, so we can't really make a distinction on that basis. There are also "drum" and "tube" magazines, but the two presented are probably the most common, at least for the use case I'm targeting.

The top one (ammunition-magazine) is probably technically referred to as a "STANAG" or "NATO" magazine used in rifles and machine guns, while the second one is a pistol or handgun magazine.

How about mdi-magazine-rifle and mdi-magazine-pistol…? It's generic enough that it (hopefully) won't offend anyone…

...though there are always going to be people out there who really know their stuff who might point out that "Well, technically, the XYZ uses the ABC magazine so you can't really call it just a 'rifle' magazine because..."

If other contributors felt so inclined that would also leave space for mdi-magazine-drum and whatever else.

We should avoid calling the icon just mdi-magazine as it might collide in future with someone wanting a "magazine" icon representing the "newspapers and magazines" kind of magazine. This is why I initially suggested ammunition-magazine, even though it's a bit verbose.

For what it's worth, I'll here are a couple of references to justify my suggestions in case others question the choice down the track: https://military.wikia.org/wiki/Magazine_(firearms) https://en.wikipedia.org/wiki/Magazine_(firearms)

Templarian commented 3 years ago

I like the suggestion for magazine-rifle / magazine-pistol. That should work. The designs need some work. We try to stay away from 1px lines. It's best to exaggerate things. So 2px lines everywhere. Even for the individual rounds. This makes it easier to see at the 1:1 size.

adlaws commented 3 years ago

I kind of wanted to avoid the implication that the icon was also showing "number of rounds in the magazine", so the intent was to have a texture on the magazine rather than show actual rounds.

From your comment though, possibly I have failed there... 😅

Do these work better for you? (new zip file also attached)