search

Templarian / ui.bootstrap.contextMenu

AngularJS Bootstrap UI Context Menu
MIT License
259 stars 127 forks source link

fix submenus not clearing #109

Closed rettgerst closed 7 years ago

rettgerst commented 7 years ago

even after implementing @dashawk's changes, submenus were not clearing (I cannot provide example code but this happened in the demo page, even). this patch fixes it the issue, for me at least.

apparently the listener was not being attached to disabled elements, which does not make sense as even disabled elements would still be outside the boundaries of the parent list item of the submenu.

josetaira commented 7 years ago

HI @rettgerst, would you mind testing your changes along with the PR at https://github.com/Templarian/ui.bootstrap.contextMenu/pull/108 ?

I did a lot of refactoring to clean the code up, and will be doing a bit more in the next few days. Before I do so though, I need some help in testing that the current code my PR introduces works.

rettgerst commented 7 years ago

actually, that branch fixes my bug already. I'll close this PR and update my project to point to that branch.