search

Templarian / ui.bootstrap.contextMenu

AngularJS Bootstrap UI Context Menu
MIT License
259 stars 127 forks source link

Add an option to compile html string to help user can add html string with their custom directives. #141

Closed hieutranagi47 closed 6 years ago

hieutranagi47 commented 6 years ago

Please take a look at: https://github.com/Templarian/ui.bootstrap.contextMenu/issues/140

pvillaverde commented 6 years ago

Hey there! When will be the next version bump? I did a bower install today and things were not working I had a compile done in my code and with the version I downloaded from bower it it hasn't got the compile funcionality yet!

Thanks! :smile:

hieutranagi47 commented 6 years ago

Hi Pvillaverde, I checked and it works perfect, it may do not change version so when you run bower install/update, your project does not update the latest code on this library.

pvillaverde commented 6 years ago

Exactly! That was what i meant. I changed computer that day and when installing dependencies I realised that this merge wasn't updated on the bower repos. I'm not sure how they work, but maybe it just needs a version bump so that changes can be seen 🤔

hieutranagi47 commented 6 years ago

Oh, so weird, you can try running "bower install angular-bootstrap-contextmenu --save" again. I did this way then it works. My bower json content: "angular-bootstrap-contextmenu": "^1.1.0"

pvillaverde commented 5 years ago

I did so, but contentMenu.js which comes into /bower_components/angular-bootstrap-contextmenu/contextMenu.js` doesn't have the changes from this merged pull, which includes the compile logic.

I've just checked if it was a bower issue doing cache, but after cleaning cache it does download the same files from here: https://github.com/Templarian/ui.bootstrap.contextMenu/archive/v1.1.0.tar.gz

bower angular-bootstrap-contextmenu#*       not-cached https://github.com/Templarian/ui.bootstrap.contextMenu.git#*
bower angular-bootstrap-contextmenu#*          resolve https://github.com/Templarian/ui.bootstrap.contextMenu.git#*
bower angular-bootstrap-contextmenu#*         download https://github.com/Templarian/ui.bootstrap.contextMenu/archive/v1.1.0.tar.gz
bower angular-bootstrap-contextmenu#*          extract archive.tar.gz
bower angular-bootstrap-contextmenu#*         resolved https://github.com/Templarian/ui.bootstrap.contextMenu.git#1.1.0
bower angular-bootstrap-contextmenu#^1.1.0     install angular-bootstrap-contextmenu#1.1.0

Check it creating a folder, doing bower init and then bower install angular-bootstrap-contextmenu --save

hieutranagi47 commented 5 years ago

Oh, you are right, I cleaned all cache on my PC, then I reproduced your steps, and I see the same problem with you, although the compilation code is already in the master branch.

pvillaverde commented 5 years ago

I've checked docs and added PR #145. It needed version bump and a tag for bower to update.

josetaira commented 5 years ago

Version bumped. Apologies for the delays.