search

Templarian / ui.bootstrap.contextMenu

AngularJS Bootstrap UI Context Menu
MIT License
259 stars 127 forks source link

New contextMenuBuilder api and several additions #27

Closed SuricateCan closed 8 years ago

SuricateCan commented 9 years ago

Several additions:

@Templarian After this PR is accepted (if you choose to) I will work on having the context menu built from a template inside the ngRepeat context.

Templarian commented 9 years ago

That's a lot of breaking changes. I can't really merge that right now. You have my permission to create a new context menu from this project though.

I'll look into the code changes eventually and try to implement them in without breaking the legacy code. I use this widget in tons of client projects and personal projects (as do many others). I have to ensure some consistency in how it works.

SuricateCan commented 9 years ago

@Templarian You dont have to worry about breaking old codes. I kept compatibility with the older versions. My own project works under the old code standards, and the new one did not break it, I made sure of it. I appreciate you giving me permission to create a new project using this one, but I rather just contribute to yours.

Templarian commented 9 years ago

Oh okay, will have to look into it some more then. I only skimmed the changes you made to the readme.

SuricateCan commented 9 years ago

I must have forgotten to mention backwards compatibility. I thought I added that line...

josetaira commented 8 years ago

Seems this PR has become conflicting. I've added in a new PR for the class name issue at https://github.com/Templarian/ui.bootstrap.contextMenu/pull/60

I'll look into the other PRs and see how to merge them into the most recent master. If you have enough time, @SuricateCan, would you be able to redo some of these?

SuricateCan commented 8 years ago

Hi @josetaira , I tried to merge upstream but there has been many changes that virtually break this PR, so I gave up on it. I would have to re-write it entirely from the current master, and I just don't have the time right now...

josetaira commented 8 years ago

Yeah, refactoring does that to pending PRs. I'll try to work on each feature when I can, and post progress under different PRs so that efforts don't get duplicated. I'll close this for now, maybe we can just reference it in the future, since it's quite impossible to merge it cleanly without too much work.