search

Templarian / ui.bootstrap.contextMenu

AngularJS Bootstrap UI Context Menu
MIT License
259 stars 127 forks source link

Marker for nested menu looks ugly in firefox #38

Closed madmas closed 8 years ago

madmas commented 8 years ago

With Firefox (tested with version 43 and 38), the marker for the nested menue is rendered in a new line, which looks ugly:

bildschirmfoto 2016-01-21 um 17 11 03

Solution is to add the (floating) marker first, I'll provide a PR in a minute.

Templarian commented 8 years ago

Thanks! Will review it shortly, but yea that definitely doesn't look nice in Firefox (kind of didn't want to use the Glyph font since a lot don't include it and opt for other font packages, especially when using themes).

jamesrom commented 8 years ago

Hey @Templarian I have checked this fix (49279e1) and it works. Can you please merge this (it's a one liner, check it out).

Firefox support is the only thing stopping me from using this otherwise awesome context menu.

Templarian commented 8 years ago

Merged, need to update the bower and npm.

josetaira commented 8 years ago

@Templarian the merge seems to have disappeared shortly after it was merged because of the refactoring that was done. I've added in a fix that closes this issue. We'll just have to update bower and npm accordingly.

guicoma commented 8 years ago

I'm not quite sure if I'm doing something wrong but the update doesn't seem to grab the correct code. Looking here at the tag of v0.9.7 it doesn't contain this fix. I guess I can grab it using the commit hash, but I believe the tag should be corrected.