search

Templarian / ui.bootstrap.contextMenu

AngularJS Bootstrap UI Context Menu
MIT License
259 stars 127 forks source link

Added ipad/left click support #57

Closed glaidler closed 8 years ago

glaidler commented 8 years ago

Minor alteration to allow left-click and ipad support.

josetaira commented 8 years ago

@glaidler changes look good. Can you check the notes I put and revert the unnecessary format changes before we merge this in?

glaidler commented 8 years ago

No problem will do. Was my ide being "helpful".

G

http://accelerata.co.uk http://accelerata.co.uk tel: 01392 580154 mob: 07968 472239 skype: glaidler

On Fri, Apr 22, 2016 at 9:16 AM, Jose Taira notifications@github.com wrote:

@glaidler https://github.com/glaidler changes look good. Can you check the notes I put and revert the unnecessary format changes before we merge this in?

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/Templarian/ui.bootstrap.contextMenu/pull/57#issuecomment-213318242

glaidler commented 8 years ago

Hi - formatting undone.

josetaira commented 8 years ago

Found some issues while testing this out. ReferenceError: $ is not defined seems to be problematic not just in this case. I'll push a fix for this issue later, but for now the more pressing issue is the click.

I think in general, we should be able to specify custom events that openMenus triggers to as requested in https://github.com/Templarian/ui.bootstrap.contextMenu/issues/43

Seems like it'd be easy to update the implementation to be more customizable.

Property name should be context-menu-custom-trigger

glaidler commented 8 years ago

Yes - this makes total sense i will adjust.

G

http://accelerata.co.uk http://accelerata.co.uk tel: 01392 580154 mob: 07968 472239 skype: glaidler

On Fri, Apr 22, 2016 at 9:44 AM, Jose Taira notifications@github.com wrote:

Found some issues while testing this out. ReferenceError: $ is not defined seems to be problematic not just in this case. I'll push a fix for this issue later, but for now the more pressing issue is the click.

I think in general, we should be able to specify custom events that openMenus triggers to as requested in #43 https://github.com/Templarian/ui.bootstrap.contextMenu/issues/43

Seems like it'd be easy to update the implementation to be more customizable.

Property name should be context-menu-custom-trigger

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/Templarian/ui.bootstrap.contextMenu/pull/57#issuecomment-213331799

josetaira commented 8 years ago

Already fixed in https://github.com/Templarian/ui.bootstrap.contextMenu/pull/66

The PR seems to have become unnecessary.