Styling fix for Bootstrap 4

dazwin commented 8 years ago

There are not many differences when using Bootstrap 4, but a new style - dropdown-item - is now needed.

Templarian commented 8 years ago

Haven't had time to look at this, but does this change still look okay with v3.3.x?

Way behind on pull requests and releases with this (Summer).

dazwin commented 8 years ago

As I'm not using v3, I'm unable to test. However, doing a search of v3 shows that there is no mention of the dropdown-item class:

$ grep \"version\" package.json; grep -Rl dropdown-item .
  "version": "3.3.6",

Compare with v4:

$ grep \"version\" package.json; grep -Rl dropdown-item .
  "version": "4.0.0-alpha.2",
./dist/css/bootstrap.css
./dist/css/bootstrap.min.css
./dist/js/bootstrap.js
./dist/js/bootstrap.min.js
./dist/js/umd/scrollspy.js
./js/dist/scrollspy.js
./js/dist/scrollspy.js.map
./js/src/scrollspy.js
./scss/_dropdown.scss

josetaira commented 7 years ago

I've tested it out and applied this code to the latest. It should be in v1.0.1

I wasn't able to just merge it in due to the conflicts but the code should already be integrated in https://github.com/Templarian/ui.bootstrap.contextMenu/commit/bf7ec942c296e0ff07b1aefcd034189b0cc911e5

Templarian / ui.bootstrap.contextMenu

Styling fix for Bootstrap 4 #74