search

Tempus / Disciple-Monster-Train

Disciple-centric faction for Monster Train
2 stars 1 forks source link

Cinderborn really picky on what does and doesn't constitute energy gain for the attack buff #167

Open Tempus opened 3 years ago

Tempus commented 3 years ago

For instance energy 'rebated' by the Exiled Hero wasn't giving the buff

Tempus commented 3 years ago

Cinderborn maybe works better now

RisingDusk commented 3 years ago

I improved this behavior a lot in 8705bb6, but there are still edge cases where it misbehaves and seems to miss trigger fires. There don't appear to be any crashes and the code reports that they should be firing, but they never happen. This seems to happen when the draw hand coroutine competes with the gain ember coroutine at the start of a turn, but may also happen elsewhere as well. I suspect the issue could be in Trainworks and not here, actually.

In my commit, I consolidated the trigger so it only fires once for a unit and changes how much the upgrade is based on ember gained. This improved the performance and fixed a number of the previously existing trigger misfires, so it's at least better than it was.