search

TemryL / ComfyUI-IDM-VTON

ComfyUI adaptation of IDM-VTON for virtual try-on.
GNU General Public License v3.0
370 stars 40 forks source link

License conflict #52

Open imperator-maximus opened 3 months ago

imperator-maximus commented 3 months ago

Hello, you set license of this project to GPL which allows commercial use but original license is non-commercial see https://github.com/yisol/IDM-VTON/issues/13 so both are not compatible in my opinion (I am not an expert).

I recommend to change license of this repo to same - CC BY-NC-SA 4.0 so that would be a good solution.

TemryL commented 3 months ago

Hi, thanks for your comment.

GPL is inherited from ComfyUI and concern only the custom nodes.

Original IDM-VTON source code is under CC BY-NC-SA 4.0 license (as already stated in the README).

I think it's fine to keep it like this as I'm not sure I can add 2 license in the same repo. Lmk :)

spenpal commented 3 months ago

@imperator-maximus The README has the original license at the bottom, which I believe is sufficient enough.

imperator-maximus commented 3 months ago

I am not a specialized lawyer but I think it is not required to use GPL because of ComfyUI because this is an extension. This is a problem many nodes have and it would be a nice having some guidelines for extension developers.