search

Temzasse / react-modal-sheet

Flexible bottom sheet component built with Framer Motion to provide buttery smooth UX while keeping accessibility in mind 🪐
https://temzasse.github.io/react-modal-sheet/
MIT License
856 stars 80 forks source link

`draggableAt` is Not Working #168

Open anliting opened 3 months ago

anliting commented 3 months ago

draggableAt of the following example does not work on my device: https://github.com/Temzasse/react-modal-sheet/blob/HEAD/example/components/ScrollableSnapPoints.tsx https://temzasse.github.io/react-modal-sheet/#/scrollable-snap-points

What I expected is that, when the content is scrolled to top, the sheet is draggable.

shivaluma commented 1 month ago

did you manage to have a workaround ?

anliting commented 1 month ago

did you manage to have a workaround ?

No, I did not.

carlos-ribeiro-zup commented 2 weeks ago

This is pretty annoying. The drag action is only working on web browser when no device view is applied. Thinking of create a fork just to fix that problem and others already opened on pull requests.

Temzasse commented 2 weeks ago

Hey everybody! 👋🏻

Chiming in here: the draggability is not super reliable on non-touch devices and I recommend testing it with a iOS/Android simulator instead of in Chrome's mobile emulation mode.

@carlos-ribeiro-zup I'm very much open to PRs to improve the draggability/scrollability 😊

carlos-ribeiro-zup commented 2 weeks ago

Thanks for replying @Temzasse. As the issues and PRs were opened too many days ago, I thought you've kind abandoned the lib. Glad it's not, cuz you did a really nice job here.

Temzasse commented 2 weeks ago

Thanks @carlos-ribeiro-zup 👍🏻

I haven't abandoned the lib but I'm definitely much more busy nowadays so it's hard to find time to work on open source stuff 😞 Every now and then I get an energy boost and try to tackle multiple issues at once 😄