Guardian ranks - Githubissues

TenDRILLL / Argos

2 stars 0 forks source link

Guardian ranks #12

Closed TenDRILLL closed 1 year ago

TenDRILLL commented 1 year ago

Should look into implementing Guardian Ranks as one of the logged parameters into Argos.

Definition of Done:

[x] API Mappings typed
[x] Guardian Rank values saved to user information
[x] Decide if GR should be visible on Discord Connection
[x] If so, implemented

TenDRILLL commented 1 year ago

Found these: Destiny.Entities.Profiles.DestinyProfileComponent.currentGuardianRank Destiny.Entities.Profiles.DestinyProfileComponent.lifetimeHighestGuardianRank

Should be feasible, need to discuss which one to store/display. I'd go for lifetime personally.

Ugi0 commented 1 year ago

I would personally rather have it be the current guardian rank since lifetime highest might not be accurate for someone who hasn't played for a few season for example. Would be great to have the guardian rank be the same as ingame. GR should be visible in discord connection imo

TenDRILLL commented 1 year ago

Fair, we implement current then

TenDRILLL commented 1 year ago

Implemented in: 55579000ff5970535287967bc0a7884b35a7424e Testing... Works, closing.