search

TenDRILLL / Argos

2 stars 0 forks source link

LFG event timers triggered too early #17

Closed TenDRILLL closed 1 year ago

TenDRILLL commented 1 year ago

An LFG event timers for notifying and deletion triggered a day before the time. Assuming the cause to be initial timers being set for the day before, LFG edited to next day; and initial timers not being disengaged for some reason.

TenDRILLL commented 1 year ago

The creator of the LFG has confirmed the initial time corresponds to the early trigger time. Should look into edit destroying old timers properly.

TenDRILLL commented 1 year ago

Relevant logs:

Saving LFG: 912648109031567380&1097340615106232371
createTimer: 912648109031567380&1097340615106232371
Getting LFG: 912648109031567380&1097340615106232371
Getting LFG: 912648109031567380&1097340615106232371
Saving LFG: 912648109031567380&1097340615106232371
1681830000 - 1681916400
Deleting timers for: 912648109031567380&1097340615106232371
createTimer: 912648109031567380&1097340615106232371
Time: Mon, 17 Apr 2023 02:01:30 GMT
...

[THIS ENTRY REPEATS MULTIPLE TIMES, DUE TO PEOPLE JOINING/LEAVING THE LFG]
Getting LFG: 912648109031567380&1097340615106232371
Saving LFG: 912648109031567380&1097340615106232371
1681916400 - 1681916400
Times: Mon, 17 Apr 2023
02:21:30 GMT
05:26:30 GMT
06:06:30 GMT
12:21:30 GMT
12:36:30 GMT
13:01:30 GMT
15:11:30 GMT

...

Deleting LFG: 912648109031567380&1097340615106232371
Deleting timers for: 912648109031567380&1097340615106232371
Time: Tue, 18 Apr 2023 15:06:30 GMT

The logs indicate that time time was saved correctly.

TenDRILLL commented 1 year ago

Strangely enough 1681916400 translates to: Wed Apr 19 2023 15:00:00 GMT+0000. And the first log entry shows the time should've been changed, with deleting timers being called. @Ugi0 thoughts on why it failed? Maybe we should add logging to: https://github.com/TenDRILLL/Argos/blob/master/src/handlers/lfgManager.ts#L32

Ugi0 commented 1 year ago

Changed timeouts to be cleared with timer.clear() Tested that the bug is fixed