TenKeyLabs / dappwright

🏌🏼‍E2E testing for dApps using Playwright + MetaMask & Coinbase Wallet
https://www.npmjs.com/package/@tenkeylabs/dappwright
Other
83 stars 21 forks source link

"Sign in" request method #271

Closed alejogranerorequest closed 8 months ago

alejogranerorequest commented 9 months ago

Some sites request a click on a sign-in button after approving the connection with "wallet.approve()". Could you add a method to click on "Sign In"?

Another option is to modify the wallet.approve() method to manage this sign in request

cc: @osis

Screenshot 2023-12-13 at 16 55 54 Screenshot 2023-12-13 at 16 55 49
osis commented 9 months ago

oh, that's interesting. What is the complete flow for this? Does it happen before or after you approve?

alejogranerorequest commented 9 months ago

Yes, it happens right after you approve.

alejogranerorequest commented 9 months ago

A simple method for clicking over it could be enough. This is the HTML code for the Sign in button: <button class="button btn--rounded btn-primary page-container__footer-button" data-testid="page-container-footer-next" role="button" tabindex="0">Sign-In</button>

osis commented 9 months ago

alright cool. Thanks for the context.

alejogranerorequest commented 8 months ago

Hey @osis , do you have an update on this?

osis commented 8 months ago

another easy one for someone to contribute to the project. 🙏🏾 My next cycle of time for this will be through the holidays, so I'll pick up whatever is open.