TenKeyLabs / dappwright

🏌🏼‍E2E testing for dApps using Playwright + MetaMask & Coinbase Wallet
https://www.npmjs.com/package/@tenkeylabs/dappwright
Other
83 stars 21 forks source link

feat: 🎸 add new param for another extensions #293

Closed IGoRFonin closed 7 months ago

IGoRFonin commented 8 months ago

Short description of work done Add new parameter additionalExtensions for dappwright.bootstrap

Issues

Reslove #292

Closes #292

changeset-bot[bot] commented 8 months ago

🦋 Changeset detected

Latest commit: b963b89fc6b1a5de98a5b8d13fafec805170a9c2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ---------------------- | ----- | | @tenkeylabs/dappwright | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

osis commented 8 months ago

Hey @IGoRFonin! This is a really interesting contribution. How do you see this playing out with other extensions? All of the actions would need to be adjusted to the UI for that extension, so I'm curious.

IGoRFonin commented 7 months ago

@osis Hi. I use it for "webtc control" to hide my ip when I use a proxy, there is more info there https://browserleaks.com/webrtc. I do this because chromium doesn't have it out of the box.

Example:

image

chromium i use from playwright-extra with extra features to block bot detection.

osis commented 7 months ago

ah I see. Thanks for clarifying. Sounds like a great usecase. Other thing I would like to clarify in the interface that these are additionalExtensions or otherExtensions since the wallet is an extension itself and installing multiple can cause issues.

IGoRFonin commented 7 months ago

Change parameter name.

osis commented 7 months ago

Thanks for the contribution! 🥳