Tencao / MoreBees

a mod that adds more bees to minecraft forestry
11 stars 12 forks source link

[1.10.2] Rock Hive generation #73

Open Steve505 opened 6 years ago

Steve505 commented 6 years ago

Hi there! In our server modpack, More Bees randomly generates Rock Hive and few blocks of Iron and Coal ore (their total is always 5) on surface, specificly on the planets from Galacticraft, Galacticraft Planets and Extra Planets, then also in the Aroma1997's Dimensional World. It looks quite irrational, when you see a hive on the planet without life, or even without oxygen... Is there a way to turn it off? I would appreciate any help.

Thanks, Jason505

2017-12-27_19 19 53 2017-12-27_19 19 59

Tencao commented 6 years ago

I'm currently rewriting MoreBees and can easily do this. At the very least I can disable ore gen around the hives, but I'll also see to adding a dimension blacklist to the config

Steve505 commented 6 years ago

Great news! When do you think it'll be done? We're going to open the server in few weeks, so it could be good to know if we should open it or wait for update of this mod.

Thanks, Jason505

Tencao commented 6 years ago

The code is mostly done but I'm unsure if I will be supporting versions lower than the latest, so currently it's unknown.

Steve505 commented 6 years ago

I understand, but I think the 1.10.2 version will be base of most modpacks at least for few next months... Anyway, thanks for the solution! Time will tell...

Tencao commented 6 years ago

Most of my modpacks are on the latest version, thus that is my main focus. I can downgrade the code all the way up to 1.7.10, but outside of this taking development time, most previous versions aren't always used. If I was to support old versions, I'd probably only support 1.7.10, 1.10.2 and 1.11.2, but it all depends on how much work is required for this.

Steve505 commented 6 years ago

Hey there! I just want to know, if you're in the mood to do this. Time for opening the server is coming and we have to finalize the modpack. No criticism in it at all, compared to other mod developers, you have great response for issues. Other unnamed developers just ignore bugs in their mods. So, big plus for you!

Thanks for your willingness. Jason505

Tencao commented 6 years ago

I've mostly been testing and fixing the changes I've made, hopefully I'll get around to pushing an update out tomorrow and if the change back to 1.10 isn't too much of a problem, then I'll also push that out as well but no guarantees.

Steve505 commented 6 years ago

Hey again! It was almost 3 months and still nothing happened. At least we need to know, if there'll be an update or not...

Thanks, Jason505

Tencao commented 6 years ago

It's more related to getting the port working, this was fixed in the 1.12 branch but I've had issues porting the events to 1.11 and 1.10 properly.

Steve505 commented 6 years ago

All right... And what about the possibility to turn off generation of invidually hives, so that we could just turn off Rock Hive generation, and then add it via. custom generation mod/plugin?

Tencao commented 6 years ago

I'm currently rewriting parts of the code now so it's more port friendly, however still have a few small issues in testing that need to be resolved such as it loading before forestry despite it should be after

Steve505 commented 6 years ago

How does it look like after another three months? At least if there will be the world blacklist or something like that....

Tencao commented 6 years ago

On the latest 1.12 build, the generation is removed for the hives ores. Once I get confirmation that the new build has no major bugs, I'll port it to 1.10/1.11

Tencao commented 6 years ago

Nevermind, I actually re-read the issue at hand and originally assumed it was just relating to the hives ores. I'll see about adding a dim blacklist however since the generation is handled by forestry, it all depends on their api

Edit - Actually double checking, I did implement this blacklist already, so it's just a case of porting