support build python library on Windows

Tencent / MMKV

An efficient, small mobile key-value storage framework developed by WeChat. Works on Android, iOS, macOS, Windows, and POSIX.

Other

17.2k stars 1.88k forks source link

support build python library on Windows #1287

Closed BeneficialCode closed 3 months ago

BeneficialCode commented 3 months ago

Test on Windows with msvc compiler.

tencent-adm commented 3 months ago

All committers have signed the CLA.

lingol commented 3 months ago

Thanks for your contribution. However, there's too much duplication between POSIX/Python and Win32/Python. Can you make the duplication go away? Maybe move the Python folder out of POSIX?

POSIX/ Python/ (with potential modification to CMakeLists.txt to support both POSIX & Win32) Win32/

lingol commented 3 months ago

Also, we don't accept PRs into the master branch directly. Please change the target branch to the dev branch.