support build python library on Windows

Tencent / MMKV

An efficient, small mobile key-value storage framework developed by WeChat. Works on Android, iOS, macOS, Windows, and POSIX.

Other

17.2k stars 1.89k forks source link

support build python library on Windows #1288

Closed BeneficialCode closed 3 months ago

BeneficialCode commented 3 months ago

Test on Windows with msvc compiler. Now I'm comming!

tencent-adm commented 3 months ago

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

:white_check_mark: lingol
:white_check_mark: BeneficialCode
:white_check_mark: colmugx
:x: xiezheng-XD
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

BeneficialCode commented 3 months ago

I have signed the CLA already but the status is still pending. Recheck is not useful. I don't know the reason.

lingol commented 3 months ago

Hey, there are too many unnecessary commits in your PR. Please make sure you have the latest dev branch.

Also, if you can make the optimization of code structure, I will be most grateful. https://github.com/Tencent/MMKV/pull/1287#issuecomment-2097895096

BeneficialCode commented 3 months ago

Okay, I will try my best.