Tencent / PhoenixGo

Go AI program which implements the AlphaGo Zero paper
Other
2.88k stars 577 forks source link

Faqv4 bazel master : add benchmark Tesla V100 + minor readme changes #90

Closed wonderingabout closed 5 years ago

wonderingabout commented 5 years ago

@wodesuck

general look here : https://github.com/wonderingabout/PhoenixGo/tree/faqv4-bazel-master

2 main changes in this PR :

1) add benchmark Tesla V100 :

this benchmark showed a few interesting conclusions :

These numbers may change if PhoenixGo supports newer Tensorflow versions, as well as newer tensorRT versions too of course (latest is tensorRT 5.0 which brings native support for RTX and tesla V100)

latest stable version is tensorflow 1.13 close to final release : https://github.com/tensorflow/tensorflow/releases

tensorflow 1.13 changelog says this in : https://github.com/tensorflow/tensorflow/releases/tag/v1.13.0-rc2

TensorFlow GPU binaries are now built against CUDA 10 and TensorRT 5.0.

so i think it would be very great to support tensorflow 1.13 with PhoenixGo

benchmark gtx1060 75W has been slightly updated as well

2) add "undo" on readme + add FAQ question + other minor readme changes

other minor readme updates (i checked on list_commands and undo appears at the bottom of the list now) another new FAQ question A8.

conclusion : after merging this, i think it PhoenixGo may want to look at tensorflow support of newer versions like 1.12 or 1.3, as well as tensorRT 5.0 (to add support for RTX cards, and native support for Volta (no need to build model anymore))

tencent-adm commented 5 years ago

CLA assistant check
All committers have signed the CLA.

wonderingabout commented 5 years ago

@wodesuck

i will do again all the benchmarks when PhoenixGo supports tensorflow 1.13, this will be a major speed improvement, as well as native support for nvidia RTX and Volta

i will also update the bazel and readme documentation, and i am willing to help for the testing if needed

wonderingabout commented 5 years ago

@zxkyjimmy

you release the PhoenixGo update for tensorflow 1.8 in https://github.com/Tencent/PhoenixGo/commit/6b17598bd4b249d78112f76f5d35272b64d31605

can we do something for tensorflow 1.13 too, for support of cuda 10.0 and tensorrt 5.0 in RTX cards and Volta ? big thanks

see tensorflow 1.13 changelog : https://github.com/tensorflow/tensorflow/releases/tag/v1.13.0-rc2

TensorFlow GPU binaries are now built against CUDA 10 and TensorRT 5.0.

zxkyjimmy commented 5 years ago

It's my pleasure. But I have a lot of deadlines to handle. I will start this work next week.

wonderingabout commented 5 years ago

@zxkyjimmy

it is also my pleasure :+1:

whenever you can, the potential speed improvements that we can expect from tensorRT computation are arround 40% or more, as compared to notensorrt on Volta and RTX

i will do all the testing when your work is ready, big thanks :+1:

wonderingabout commented 5 years ago

today again, phoenixgo proved to play very smart and complex game, very satisfying :+1: let's keep improve phoenixgo further ! :+1: https://online-go.com/game/16674632

alreadydone commented 5 years ago

Yeah surely phoenixgo needs improvement as it's losing 14 games in a row to LZ on Fox! (LZ has 4xV100; not sure about phoenixgo but feel free to improve it with hardware!)

wonderingabout commented 5 years ago

@alreadydone

4 V100 for a 40b, vs we dont know what, if i remember correctly it's a Tesla P40, so it should not give more than 0.5 V100, right @wodesuck ?

of course the comparison would be unfair then :+1:

but it is always interesting to have diversity, we gain knowledge from that

wonderingabout commented 5 years ago

@zxkyjimmy small update just to notify you that tensorflow 1.13.1 final version just got released yesterday as @l1t1 told me https://github.com/tensorflow/tensorflow/releases

i know many things can take time, so whenever you can for PhoenixGo i will be always happy :+1:

zxkyjimmy commented 5 years ago

I see. (((o(゚▽゚)o)))

wonderingabout commented 5 years ago

@zxkyjimmy

✺◟(∗❛ᴗ❛ั∗)◞✺

wonderingabout commented 5 years ago

big thanks @wodesuck :+1: