pgxc_node_str() function is broken (XL regression)

Tencent / TBase

TBase is an enterprise-level distributed HTAP database. Through a single database cluster to provide users with highly consistent distributed database services and high-performance data warehouse services, a set of integrated enterprise-level solutions is formed.

Other

1.38k stars 261 forks source link

pgxc_node_str() function is broken (XL regression) #52

Closed yazun closed 3 weeks ago

yazun commented 4 years ago

Returns pointer as function is thinking GUC being returned is varlena. XL has proper implementation..

JennyJennyChen commented 4 years ago

Can you provide detailed information ？(for example: expectations, actual conditions, comparison with PGXL, etc.)

yazun commented 4 years ago

It was not returning expected results (garbage): fix is here https://github.com/yazun/TBase/commit/31ea61bb4ea15d778456c46bcd20694425b589c3

JennyJennyChen commented 4 years ago

Thanks for your fix