search

Tencent / TubeMQ

TubeMQ has been donated to the Apache Software Foundation and renamed to InLong, please visit the new Apache repository: https://github.com/apache/incubator-inlong
https://inlong.apache.org/
2.02k stars 391 forks source link

[docs] Update http_access_API_definition.md #110

Closed Jennifer88huang-zz closed 4 years ago

chenjunjiedada commented 4 years ago

Nice work @Jennifer88huang, will you go through full doc? It looks like there are some other places need to be updated as well.

Jennifer88huang-zz commented 4 years ago

@chenjunjiedada For the editorial issues, I can update it further. However, some improvement requires correct understanding of the sentence, I'm not quite sure whether I could grasp the right meaning from the current content, that's why I stop here with some tiny suggestions.

chenjunjiedada commented 4 years ago

@Jennifer88huang, I think you could go ahead and update according to your understanding, we will review changes as well.

konjac commented 4 years ago

|brokerId|yes|the id of broker. It supports bulk brokerId which separated by ,. The maximum
number of a bulk is 50. The brokerId should be distinct in case of bulk value |int|

remove which

Refers to: docs/http_access_API_definition.md:75 in 11f2234. [](commit_id = 11f2234f78e1a02941a96239b80137960e5387a3, deletion_comment = False)

chenjunjiedada commented 4 years ago

@konjac, since this PR has no update for a while, I would encourage you to submit a separate PR for your suggestions. I would do a quick merge for this PR.

+1 to merge this first. @gosonzhang, thoughts?

gosonzhang commented 4 years ago

+1