search

Tencent / TubeMQ

TubeMQ has been donated to the Apache Software Foundation and renamed to InLong, please visit the new Apache repository: https://github.com/apache/incubator-inlong
https://inlong.apache.org/
2.02k stars 391 forks source link

Shielding abnormal broker should not be limited to IOException, any exception in the writing process should be managed. #137

Closed Libeibei1990 closed 4 years ago

Libeibei1990 commented 4 years ago

Shielding abnormal broker should not be limited to IOException, any exception in the writing process should be managed. For example, modify writing path permission which will affect data writing directly.

https://github.com/Tencent/TubeMQ/blob/master/tubemq-server/src/main/java/com/tencent/tubemq/server/broker/msgstore/disk/MsgFileStore.java

catch (final IOException e) { ServiceStatusHolder.addWriteIOErrCnt(); logger.error("[File Store] Append message in file failed ", e); throw e; }

gosonzhang commented 4 years ago

Thanks, I'll check it and fix it.