search

Tencent / TubeMQ

TubeMQ has been donated to the Apache Software Foundation and renamed to InLong, please visit the new Apache repository: https://github.com/apache/incubator-inlong
https://inlong.apache.org/
2.02k stars 391 forks source link

tubemq-server module should remove the dependency of tubemq-example module #18

Closed ykgarfield closed 4 years ago

ykgarfield commented 5 years ago

Now, the tubemq-server module depend on tubemq-example module, as shown of tubemq-server pom.xml:

<dependency>
    <groupId>com.tencent.tubemq</groupId>
    <artifactId>tubemq-example</artifactId>
</dependency>

In theory, tubemq-server should not depend on tubemq-example.

tisonkun commented 5 years ago

Hi @ykgarfield I think you're right. Is there any existing dependencies from tubemq-server to tubemq-example? If not, we can directly remove this code snippet; if so, maybe it is worth separated issues to resolve the unreasonable dependencies respectively.

ykgarfield commented 5 years ago

I check the code, no dependencies from tubemq-server to tubemq-example, also I remove the dependency and run in IDE, it's no problem.

tisonkun commented 5 years ago

Thanks for your investigation. It would be nice if you open a pull request to this issue :-)