search

Tencent / TubeMQ

TubeMQ has been donated to the Apache Software Foundation and renamed to InLong, please visit the new Apache repository: https://github.com/apache/incubator-inlong
https://inlong.apache.org/
2.02k stars 391 forks source link

Refactor MAMessageProducerExample #52

Closed tisonkun closed 4 years ago

tisonkun commented 4 years ago
  1. eliminates Chinese comments
  2. generalises types such as TreeMap -> Map
  3. mark effective final fields as final
  4. rename variable a bit and other nit refators

Still mark as draft pull request because we need a javadoc to this example explain what this example really is. And javadoc of main at least to explain the usage.

Could you help with the document side @gosonzhang?

gosonzhang commented 4 years ago

I think it's ok.

tisonkun commented 4 years ago

@gosonzhang any updates?

tisonkun commented 4 years ago

merge once travis gives green